fix: logic for stubbing outgoing http and fetch-event #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix=remove-http-independent-of-fetch-event
branch
2 times, most recently
from
a8f3b9b to
b314f06
Compare
tschneidereit
approved these changes
Jul 22, 2025
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Feel free to land this as-is, but I'd much like a follow-up PR with the "remove fetch" change I suggested inline.
This commit fixes one bug and refactors the code to be more granular in the case of differing feature sets. The reality is more nuanced -- as we must stub wasi:http/types differently depending on whether fetch-event is separately enabled.
Co-authored-by: Till Schneidereit <till@tillschneidereit.net>
vados-cosmonic
force-pushed
the
fix=remove-http-independent-of-fetch-event
branch
from
540876d to
44c13ef
Compare
This was referenced Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes one bug and refactors the code to be more granular in the case of differing feature sets.
The reality is more nuanced -- as we must stub wasi:http/types differently depending on whether fetch-event is separately enabled.
Resolves #265