This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Update the minimum supported Rust version to 1.29.#569
Merged
sunfishcode merged 2 commits intobytecodealliance:masterfrom Oct 31, 2018
Merged
Update the minimum supported Rust version to 1.29.#569sunfishcode merged 2 commits intobytecodealliance:masterfrom
sunfishcode merged 2 commits intobytecodealliance:masterfrom
Conversation
bjorn3
suggested changes
Oct 24, 2018
|
|
||
| language: rust | ||
| rust: | ||
| - stable |
Member
Author
There was a problem hiding this comment.
We don't want to immediately update to stable when new versions are released because we're following Firefox's policy.
Contributor
|
We no longer need the Ubuntu LTS restriction, so now the only only constraint I'm aware of is Firefox's policy. Fortunately, that tracks the latest stable delayed by only two weeks. So this puts is at Rust 1.29 now.
sunfishcode
force-pushed
the
rust-1.29
branch
from
5991b20 to
8765561
Compare
Member
Author
|
A new version of flake8 added some new warnings. These are now fixed. |
This re-introduces several cleanups that we previously deferred for not supporting Rust 1.25.
Contributor
|
This is great! Once this lands, I'll update preopt to use rustc_apfloat. |
Member
Author
|
Ok, let's land this! |
This was referenced Oct 31, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need the Ubuntu LTS restriction, so now the only only
constraint I'm aware of is Firefox's policy. Fortunately, that tracks
the latest stable delayed by only two weeks. So this puts is at
Rust 1.29 now.
If anyone is aware of other important constraints that we should follow,
please bring them up!