Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Derive Hash for some types#869

Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:derive-hash
Jul 27, 2019
Merged

Derive Hash for some types#869
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:derive-hash

Conversation

@mrowqa
Copy link
Contributor

@mrowqa mrowqa commented Jul 25, 2019

Required by bytecodealliance/wasmtime#221. Version bump is needed, too.

@mrowqa mrowqa marked this pull request as ready for review July 25, 2019 00:21
@mrowqa
Copy link
Contributor Author

mrowqa commented Jul 25, 2019

Note: maybe it's better to wait with this PR, since bytecodealliance/wasmtime#221 is not completed and might require Hash implemented on more cranelift types.

@mrowqa
Copy link
Contributor Author

mrowqa commented Jul 26, 2019

@sunfishcode you can merge this PR and bump the version, so I can update dependencies for bytecodealliance/wasmtime#221.

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sunfishcode sunfishcode merged commit 4b27419 into bytecodealliance:master Jul 27, 2019
@mrowqa mrowqa deleted the derive-hash branch July 29, 2019 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants