Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Random refactorings#959

Merged
bnjbvr merged 3 commits intobytecodealliance:masterfrom
bnjbvr:random-refactorings
Sep 3, 2019
Merged

Random refactorings#959
bnjbvr merged 3 commits intobytecodealliance:masterfrom
bnjbvr:random-refactorings

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Aug 30, 2019

(premises for next PR)

  • first commit allows to retrieve a register like r15, which will be needed in the next PR
  • second commit moves the only static function in regalloc::coloring back into the impl block, using a trick to quiet the borrow-checking gods.
  • third commit just tweaks comments.

bnjbvr added 3 commits August 29, 2019 15:51
This makes it possible to look up registers like r15 on x86.
…thod;

It was implemented this way before to avoid borrow-checking issues,
where self would be both mutably borrowed (because of the solver) and
immutably borrowed (because of the ABI parameters list). This is worked
around by adding a local AbiParams struct which contains a summary of
the information that's needed by program_input_abi, allowing to retrieve
the ABI params within the method's body itself.
@bnjbvr bnjbvr merged commit 2072052 into bytecodealliance:master Sep 3, 2019
@bnjbvr bnjbvr deleted the random-refactorings branch September 3, 2019 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants