wit/bindgen: flattened worlds with versioned feature gates cannot be correctly serialized

[rvolosatovs]

Bindgen from latest main (cfe612d) fails to generate bindings for:

package repro:repro@0.1.0;

world importsx {
    include wasi:cli/imports@0.2.1;
}

when invoked via:

go run go.bytecodealliance.org/cmd/wit-bindgen-go generate -w importsx -o bindings ./wit

There's a lot of output, but last lines are:

error: wasm-tools: error: interface not found in package
     --> component.wit:35:21
      |
   35 | 	import wasi:clocks/timezone@0.2.1;
      |                     ^-------

exit status 1

It successfully generates bindings, however, for:

package repro:repro@0.1.0;

world imports {
    include wasi:cli/imports@0.2.1;
}

when invoked via:

go run go.bytecodealliance.org/cmd/wit-bindgen-go generate -w imports -o bindings ./wit

It seems that naming the world anything other than imports triggers this bug. I'm not sure if it's somehow correlated with the fact that the included world's name is also imports, but I would guess that's what's causing this.

Reproducer available at https://github.com/rvolosatovs/go-bindgen-repro

See rvolosatovs/go-bindgen-repro@766add4 for a working setup (with the world named imports)

env:

wasm-tools 1.227.1

go version go1.23.5 darwin/arm64

Seems related to #281
maybe related to #285 ?

[ydnar]

Can you reproduce this on main?

[rvolosatovs]

Can you reproduce this on main?

Yes, I'm using main

[ydnar]

I think I’ve tracked it down—the issue is related to feature gates, e.g. @unstable(feature = clocks-timezone).

[ydnar]

Can you try main now?

[rvolosatovs]

I've updated the bindgen, unfortunately the binding generation still fails, however the error message has changed:

go run go.bytecodealliance.org/cmd/wit-bindgen-go@main generate -w importsx -o bindings ./wit

fails with:

error: wasm-tools: error: failed to process world item in `repro-repro-WORLD-importsx-v010`

Caused by:
    0: feature gate cannot reference unreleased version 0.2.0 of package [repro:repro@0.1.0] (current version 0.1.0)
            --> component.wit:5:18
             |
           5 | 	import wasi:cli/environment@0.2.1;
             |                  ^----------

exit status 1

Interestingly, naming the world imports, once again, fixes the issue, so somehow this is still connected to the world name.

You should be able to reproduce this yourself doing something like (on Linux/Mac/WSL):

$ cd $(mktemp -d)
$ git clone https://github.com/rvolosatovs/go-bindgen-repro.git
$ cd go-bindgen-repro
$ go run go.bytecodealliance.org/cmd/wit-bindgen-go@main generate -w importsx -o bindings ./wit

[ydnar]

I was unable to reproduce with current main code of this repo (v0.6.2), with either world named imports or importsx.

[ydnar]

I noticed your go.mod file refers to an older version of this module. Running go mod tidy removes it. Have you considered adding a tools.go file, or using Go 1.24’s go tool?

https://blog.howardjohn.info/posts/go-tools-command/