feat: GC finalization for preview2-shims#357
Merged
guybedford merged 4 commits intomainfrom Jan 25, 2024
Merged
Conversation
added 2 commits
January 24, 2024 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the GC integration for the JS preview2-shims bindings, where if a
Symbol.disposecall is not done for any resource, the GC will always kick in and handle the resource finalization in this case.This is typically only for invalid components, but also affects direct usage of the preview2 APIs from JS where manual
Symbol.disposecalls are forgotten to be called by a consumer.One complexity here is that when the GC runs, it can dispose parent resources before their children. To avoid this, we create a strong reference in the finalizer for any child resource to its parent resource, so that this is not possible by the semantics of the GC itself. Thanks to @alexcrichton for suggesting the approach to this problem here. GC tests are included in the preview2 unit tests using the
--expose-gcoption in Node.js, verifying the GC integration, and that these ordering bugs are avoided.Resolves #335.