Merged
Conversation
added 2 commits
June 12, 2023 16:22
This was referenced Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to
0xdof the component model featuring the latest WIT syntax.Some careful handling was required to adapt the new namespacing model. Specifically along the lines as outlined for the ESM integration in WebAssembly/component-model#198 (comment).
That is - we treat namespace imports and exports as unsupported in the ESM integration for now, and then adopt a convention that treats namespaces as if they were being converted into kebab names to support ESM integration.
For exports, this means flattening the names as distinct exported interfaces as the combined external and package interface name. With the simplification that if there is no other export of that interface name, we can export the interface name directly.
Symmetrically for imports, we then group by package name and treat interfaces as if they were exported by a singular package module. This should allow for package imports and exports to engage in basic reciprocal dependence under this convention. When namespaced imports are combined with custom
--mapmappings, custom mappings will be applied before the convention to the combined namespace and package name.These conventions are very much experimental and better techniques for defining module boundaries will likely emerge in future.
For now the ComponentizeJS test is disabled pending the corresponding ComponentizeJS upgrade.