This repository was archived by the owner on Mar 24, 2022. It is now read-only.
When the heap is not page aligned, fail instead of lucet_bail#486
Merged
fst-crenshaw merged 7 commits intomasterfrom Apr 9, 2020
Merged
When the heap is not page aligned, fail instead of lucet_bail#486fst-crenshaw merged 7 commits intomasterfrom
lucet_bail#486fst-crenshaw merged 7 commits intomasterfrom
Conversation
4 tasks
acfoltzer
suggested changes
Apr 6, 2020
Co-Authored-By: Adam C. Foltzer <acfoltzer@fastly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a conversation over in #458, it was discovered that when creating an Instance, if its heap is not page-aligned, we'd like for the lucet runtime to panic. It's difficult to imagine how one might recover from such misalignment.
This PR makes this small fix.