This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Conversation
Closed
pchickey
force-pushed
the
pch/wasmtime_has_wiggle_ptr_stuff
branch
from
8b3d89e to
1bdff6c
Compare
pchickey
changed the title
Closed
Contributor
Author
|
The virtual pipe abstraction is now passing tests downstream (in our private code), so I'm now satisfied that this PR is ready to go! |
pchickey
changed the title
Merged
Upgrade to Rust 1.44.1
jedisct1
approved these changes
Jul 9, 2020
Contributor
jedisct1
left a comment
jedisct1
left a comment
There was a problem hiding this comment.
Works totally fine here, including on macOS.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several package version and minor interface bumps to pull in the latest wasmtime
mainbranchAdam did the majority of the work in #564 to get wasi-common to have a virtual pipe implementation upstream. Virtual pipes are now used throughout the Lucet tests instead of unix pipes.
Wiggle's borrow checker was factored out upstream, this PR copies the previous implementation to live in the Lucet crate and fixes up the implementation of wiggle's
GuestMemorytrait to use our own version.