This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Conversation
By replacing the expected yield value from a Box<PhantomData<T>> to TypeId, it becomes possible to resume instance execution when the size of a boxed type is unknown and cannot be passed as an argument. This makes it possible to yield and resume from an async context by passing the resumption value through RunAsyncState. Finally, we have to check that the context didn't change between resumption within try_block_on, in order to make sure the right Waker is scheduled and the future will be resumed when it is ready.
pchickey
force-pushed
the
pch/custom-run-async-future
branch
from
2b80350 to
4773acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.