This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Update wasmtime, now with shiny new api#659
Merged
Conversation
only minor change I had to make was around AsyncConf in wiggle
acfoltzer
approved these changes
Jun 10, 2021
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Thanks for splitting up the commits like this, made for an easy review despite the lorge diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the wasmtime submodule to the latest
main, which has landed the new-api PR.Deletes all of the crates temporarily vendored in #655, points all those dependencies back into the wasmtime submodule.
Some small adjustments for changes between vendoring and landing new-api: I unwound a knot around wiggle-generate's AsyncConf/AsyncFunctions, I had to turn off wiggle's wasmtime integration, and the runtime borrow checker is no longer in a separate crate.
The latest wasmtime submodule was no longer compatible with Rust 1.50.0, so I upgraded to 1.52.1, and fixed all the ensuing warnings which require us to change
panic!(TerminationDetails...)tostd::panic::panic_any(TerminationDetails...).