This repository was archived by the owner on Oct 13, 2023. It is now read-only.
fix: symlink wit, rather than using relative paths#134
Closed
rvolosatovs wants to merge 1 commit intobytecodealliance:mainfrom
Closed
fix: symlink wit, rather than using relative paths#134rvolosatovs wants to merge 1 commit intobytecodealliance:mainfrom
wit, rather than using relative paths#134rvolosatovs wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This enables downstream builds utilizing `cargo vendor`, since `cargo vendor` resolves symlinks before packaging crates up Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Member
Author
|
Thanks @ipetkov for 100% correct analysis of this ipetkov/crane#271 (comment) |
Member
Author
|
Alternative, and probably cleaner solution could be adopting something like https://github.com/rvolosatovs/depit once bytecodealliance/wit-deps#9 is implemented, such that the |
Member
Author
Member
|
Yeah, I agree that symlinks can be tricky here. Fortunately #136 sounds like a good option. |
Member
Author
|
Closing in favor of #136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables downstream builds utilizing
cargo vendor, sincecargo vendorresolves symlinks before packaging crates upCloses #133