This repository was archived by the owner on Oct 13, 2023. It is now read-only.
Merged
Conversation
Collaborator
pchickey
commented
Apr 17, 2023
pchickey
commented
- Adapter had an incorrect assertion
- Adapter returned wrong len in the case of truncation
- Test now expects truncation behavior
- Test and truncation behavior changes backported to wasmtime wasi-common: change behavior of path_readlink to truncate on too-small buffer wasmtime#6225
added 2 commits
April 17, 2023 14:32
truncation behavior is backported to upstream in bytecodealliance/wasmtime#6225
dicej
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.