This repository was archived by the owner on Oct 13, 2023. It is now read-only.
remove test expectations around rights#153
Merged
sunfishcode merged 5 commits intomainfrom Apr 24, 2023
Merged
Conversation
added 3 commits
April 21, 2023 12:27
This reverts commit 087179a.
…r rights bytecodealliance/wasmtime#6265 note, im leaving out upstream changes to fd_readdir which are from bytecodealliance/wasmtime#6163, which requires porting the rest of that PR into this repo
added 2 commits
April 24, 2023 12:26
which was deleted upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sync with bytecodealliance/wasmtime#6265 upstream - we are no longer using the rights field for anything other than setting a file as read or write in path_open, and never inspecting any of the rights given in fdstat.
This doesn't get any additional tests passing, just the deletion of the failing test
path_open_read_without_rights. It does remove a bunch of special casing we introduced earlier in this repo.Right now we diverge from upstream's wasi-tests: