This repository was archived by the owner on Oct 13, 2023. It is now read-only.
use main module's cabi_realloc instead of memory.grow#74
Merged
dicej merged 2 commits intobytecodealliance:mainfrom Feb 1, 2023
Merged
use main module's cabi_realloc instead of memory.grow#74dicej merged 2 commits intobytecodealliance:mainfrom
cabi_realloc instead of memory.grow#74dicej merged 2 commits intobytecodealliance:mainfrom
Conversation
This depends on bytecodealliance/wasm-tools#900, which will polyfill an implementation if the main module does not export it. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Feb 1, 2023
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on bytecodealliance/wasm-tools#900, which will polyfill an implementation if the main module does not export it.
This is a draft for now, since CI will fail until the above PR is merged and thewit-componentdependency is updated.Signed-off-by: Joel Dice joel.dice@fermyon.com