This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Simplifying the client API and refactoring federation#268
Merged
Conversation
This was referenced May 3, 2024
macovedj
reviewed
May 3, 2024
macovedj
reviewed
May 3, 2024
lann
reviewed
May 3, 2024
Collaborator
lann
left a comment
lann
left a comment
There was a problem hiding this comment.
Only critical question is about interaction in client.
| let package_name = &packages.get(log_id).unwrap().name; | ||
|
|
||
| if self.auto_accept_federation_hints | ||
| || Confirm::with_theme(&ColorfulTheme::default()) |
Collaborator
There was a problem hiding this comment.
Having this kind of interaction deep in the client like this means it isn't a general purpose client any more, it is specialized to CLIs. Given recent discussions should we give up on this crate being a general-purpose client library?
Collaborator
Author
There was a problem hiding this comment.
Yeah, this crate is only being used for CLIs at the moment. I was leaning towards simplifying this crate for that use case.
Collaborator
Author
There was a problem hiding this comment.
@lann Fine as is? Feature flag?
If refactored into a callback, it would need be async. Started looking complex and wasn't sure it was worthwhile.
…package if not initialized and doing a package publish
lann
reviewed
May 3, 2024
lann
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts to simplify the client API and enables using federation in importing crates such as
cargo-componentandwac.Draft PR for
cargo-componentDraft PR for
wac