This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Improved package init and publish flow#269
Merged
calvinrp merged 14 commits intobytecodealliance:mainfrom May 7, 2024
Merged
Conversation
macovedj
reviewed
May 6, 2024
macovedj
reviewed
May 6, 2024
This was referenced May 6, 2024
lann
reviewed
May 7, 2024
Collaborator
lann
left a comment
There was a problem hiding this comment.
Negative feature comment is only blocker
lann
reviewed
May 7, 2024
lann
reviewed
May 7, 2024
Collaborator
Author
|
Also, added a |
lann
reviewed
May 7, 2024
Collaborator
There was a problem hiding this comment.
Sorry I completely missed these changes in my first pass: "Large diffs are not rendered by default." 🙄
lann
reviewed
May 7, 2024
lann
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When publishing either a package
ReleaseorInit, a new errorConflictPendingPublish(RecordId)may be returned.This instructs the client that it could wait for the conflicting pending record (on the same
LogIdpackage) to complete and then retry to publish.If a registry service offers key management and needs to sign the
Initrecord, this enables a smoother experience and messaging on the CLI. Where the registry would return theRecordIdof the registry signedInitrecord as aConflictPendingPublisherror, the CLI would wait for that record to publish and then retry. Since the package is already initialized, an error message would be presented that indicates that the package was initialized but not with theInitrecord that you signed.Also, added a feature flag for
cli-interactivefor thewarg-clientand a config flag to disable dialoguer interactive prompting even when that feature is enabled.