Add support for Netlink sockets#1079
Closed
ids1024 wants to merge 2 commits intobytecodealliance:mainfrom
Closed
Conversation
The `SocketAddr*` types are documented to have a potentially different representation from the C types. Presumably this should use the size of the C type.
Contributor
Author
|
Ah, I guess this (and making the socket code less redundant) is covered in #1004. I didn't really expect anyone else would have tried adding Netlink support recently. Though I guess the |
Member
|
Closing, as I believe #1004 now implements this, and removes the code where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
msg_namelenis being set to the size ofSocketAddr*, which seems to be incorrect. So I also added a commit changing that for the existing socket address types.I wonder if some of the code here could be less redundant, but that isn't changed here.