Add ioctl_getflags and ioctl_setflags#973
Merged
sunfishcode merged 6 commits intobytecodealliance:mainfrom Dec 22, 2023
Merged
Conversation
fsavy-tehtris
force-pushed
the
ioctl-flags
branch
2 times, most recently
from
f2504be to
8a8f601
Compare
fsavy-tehtris
force-pushed
the
ioctl-flags
branch
from
8a8f601 to
498da15
Compare
Member
|
The CI failure here looks unrelated. |
sunfishcode
reviewed
Dec 19, 2023
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
fsavy-tehtris
commented
Dec 19, 2023
Contributor
Author
fsavy-tehtris
left a comment
fsavy-tehtris
left a comment
There was a problem hiding this comment.
Thanks for the feedback! I've addressed your remarks.
Contributor
Author
|
We might want to remove the |
Member
|
Could we put |
Contributor
Author
|
I'm moving to another company so I won't be able to revisit this PR as I'll lose access to this account. |
Member
|
Thanks for the PR! |
Member
|
This is released in rustix 0.38.29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #525 because the original author will not revisit it.
I'm the author of the associated PR adding the missing constants in
libc(rust-lang/libc#3396) and I was waiting on the libc 0.2.151 release.