Skip to content

fix: extension fails to load with node 24#78

Merged
GordonSmith merged 1 commit intobytecodealliance:mainfrom
GordonSmith:GH-77-OSX_WIN_ERROR
Aug 21, 2025
Merged

fix: extension fails to load with node 24#78
GordonSmith merged 1 commit intobytecodealliance:mainfrom
GordonSmith:GH-77-OSX_WIN_ERROR

Conversation

@GordonSmith
Copy link
Collaborator

fixes #77

@GordonSmith GordonSmith requested a review from Copilot August 21, 2025 20:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an extension loading issue with Node.js 24 by removing navigator polyfills that are no longer needed and may cause conflicts. The fix addresses issue #77 where the extension fails to load due to navigator global handling incompatibilities.

Key changes:

  • Removes the navigator polyfill implementation that was added for Node.js 21+ compatibility
  • Eliminates the injection of polyfills during the build process
  • Removes associated test coverage for the polyfill functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/node-polyfills.js Completely removes the navigator polyfill implementation and browser global handling
tests/navigator-polyfill.test.ts Removes all test cases that verified the polyfill functionality
esbuild.mjs Removes the injection of node-polyfills.js from both discovery and main build processes
Comments suppressed due to low confidence (1)

esbuild.mjs:658

  • The removed polyfill injection may have been addressing compatibility issues with dependencies that expect browser globals. Consider verifying that the extension still works correctly with all WASM modules and dependencies, particularly wit-bindgen-wasm, which may have relied on the navigator global or other polyfilled features.
        });

fixes bytecodealliance#77

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 1172282 into bytecodealliance:main Aug 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to start extension

2 participants