fix: extension fails to load with node 24#78
Merged
GordonSmith merged 1 commit intobytecodealliance:mainfrom Aug 21, 2025
Merged
fix: extension fails to load with node 24#78GordonSmith merged 1 commit intobytecodealliance:mainfrom
GordonSmith merged 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an extension loading issue with Node.js 24 by removing navigator polyfills that are no longer needed and may cause conflicts. The fix addresses issue #77 where the extension fails to load due to navigator global handling incompatibilities.
Key changes:
- Removes the navigator polyfill implementation that was added for Node.js 21+ compatibility
- Eliminates the injection of polyfills during the build process
- Removes associated test coverage for the polyfill functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/node-polyfills.js |
Completely removes the navigator polyfill implementation and browser global handling |
tests/navigator-polyfill.test.ts |
Removes all test cases that verified the polyfill functionality |
esbuild.mjs |
Removes the injection of node-polyfills.js from both discovery and main build processes |
Comments suppressed due to low confidence (1)
esbuild.mjs:658
- The removed polyfill injection may have been addressing compatibility issues with dependencies that expect browser globals. Consider verifying that the extension still works correctly with all WASM modules and dependencies, particularly
wit-bindgen-wasm, which may have relied on the navigator global or other polyfilled features.
});
06eecf0 to
bbed15b
Compare
fixes bytecodealliance#77 Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
bbed15b to
0747f4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #77