Fix panic when resource's owning interface is not otherwise implicitly imported#101
Merged
peterhuene merged 2 commits intobytecodealliance:mainfrom May 1, 2024
Merged
Conversation
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
commented
Apr 30, 2024
peterhuene
reviewed
Apr 30, 2024
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Looks great, just the one comment!
peterhuene
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
The issue is that when the aggregator remaps resources, it does not keep track of whether the resource's owning interface needs to be implicitly imported or not. The tracking for implicitly imported types is kept in the
namescollection. After remapping a type, it is put into thenamescollection, and those imports are then encoded inwac_graphas imports.If the owning interface is not otherwise implicitly or explicitly imported, there will be a panic because we assume the interface has been seen when we go to encode.