wac plug with registry support#106
Merged
calvinrp merged 11 commits intobytecodealliance:mainfrom May 13, 2024
Merged
Conversation
wac plug with registry support
macovedj
approved these changes
May 10, 2024
Collaborator
Author
|
@macovedj thanks for the review, but I definitely want the other maintainers to weigh in on this. |
Collaborator
There was a problem hiding this comment.
This looks good to me; I'd like to give @rylev a chance to review when he returns next week.
rylev
requested changes
May 13, 2024
Collaborator
rylev
left a comment
There was a problem hiding this comment.
Looks good to me. I just would like to see the comment about the usage of println! in the plug command addressed.
…d using the progress bar output when only one thing to do
rylev
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Warg to
0.6.0release with support for federating across multiple registries.Adds
wac plugregistry support (feature flag still but a default one).Existing behavior is unchanged:
wac plug my-component.wasm --plug helpful.wasm -o plugged.wasmBut now, you can mix in registry package names or local file paths. In any combination. Kind of fun.
It determines whether to look in the registry or local path by trying to parse as valid
namespace:package-name. Also, parses with versions innamespace:package-name@0.1.0syntax. If it is a valid package name, then it looks in the registry otherwise tries local file paths. Sopath/some-file.wasmwould be unambiguously a local file path.wac plug macovedj:hashimap-service --plug macovedj:my-component@0.0.1 -o plugged.wasm(those are packages from @macovedj WasmIO demo and that command will work if Warg is configured)
or
wac plug hashimap-service.wasm --plug macovedj:my-component@0.0.1 -o plugged.wasm