Skip to content

Comments

Publish binary artifacts#111

Merged
calvinrp merged 1 commit intobytecodealliance:mainfrom
calvinrp:binary-artifacts
May 14, 2024
Merged

Publish binary artifacts#111
calvinrp merged 1 commit intobytecodealliance:mainfrom
calvinrp:binary-artifacts

Conversation

@calvinrp
Copy link
Collaborator

@calvinrp calvinrp commented May 14, 2024

Copied and replaced publish-binaries.yml from cargo-component.

Not sure that it works and the secrets are all setup. Not sure how to test.

Addresses #105

@calvinrp calvinrp requested review from fibonacci1729 and rylev May 14, 2024 13:27
Copy link
Collaborator

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Unfortunately i don't have much insight into how the GITHUB_TOKEN is configured because i can't see the settings for this repository.

@calvinrp
Copy link
Collaborator Author

Suppose we could merge and test it

@calvinrp calvinrp merged commit 5eae487 into bytecodealliance:main May 14, 2024
@calvinrp calvinrp deleted the binary-artifacts branch May 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants