Skip to content

Comments

lazily create warg registry client#123

Merged
calvinrp merged 1 commit intomainfrom
fix-registry-bug
May 20, 2024
Merged

lazily create warg registry client#123
calvinrp merged 1 commit intomainfrom
fix-registry-bug

Conversation

@calvinrp
Copy link
Collaborator

Due to the change in the warg-client to support the .well-known config redirection, creating the client triggers lookups. So we need to adjust the code to lazily instantiate the registry client to avoid unnecessarily triggering usage.

Fixes #122

@calvinrp calvinrp requested a review from fibonacci1729 May 20, 2024 20:01
@thomastaylor312
Copy link

Thanks for the quick fix! Should this also bump the patch version to 0.2.1 so it can be released as a fix?

@calvinrp
Copy link
Collaborator Author

Thanks for the quick fix! Should this also bump the patch version to 0.2.1 so it can be released as a fix?

Technically, it changes a pub method to &mut self from &self. It might be better as 0.3.0. Is that OK, @thomastaylor312 ?

@thomastaylor312
Copy link

Oh yep you're right. Definitely a 0.3 in that case IMO, but really up to you

@calvinrp calvinrp merged commit 7f789ad into main May 20, 2024
@calvinrp calvinrp deleted the fix-registry-bug branch May 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CLI flag to disable registry fetching

3 participants