Add first version of targets command#132
Merged
rylev merged 3 commits intobytecodealliance:mainfrom Aug 12, 2024
Merged
Conversation
peterhuene
reviewed
Jul 18, 2024
Member
peterhuene
left a comment
There was a problem hiding this comment.
Looks great, just some minor comments.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
fibonacci1729
approved these changes
Aug 1, 2024
Collaborator
fibonacci1729
left a comment
There was a problem hiding this comment.
This looks great! Just need to resolve the one remaining comment about the positional arguments.
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
mergify bot
referenced
this pull request
in andrzejressel/pulumi-gestalt
Sep 5, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [wac-graph](https://redirect.github.com/bytecodealliance/wac) | workspace.dependencies | minor | `0.5.0` -> `0.6.0` | --- ### Release Notes <details> <summary>bytecodealliance/wac (wac-graph)</summary> ### [`v0.6.0`](https://redirect.github.com/bytecodealliance/wac/releases/tag/v0.6.0) [Compare Source](https://redirect.github.com/bytecodealliance/wac/compare/v0.5.0...v0.6.0) #### What's Changed - set version 0.6.0-dev by [@​calvinrp](https://redirect.github.com/calvinrp) in [https://github.com/bytecodealliance/wac/pull/135](https://redirect.github.com/bytecodealliance/wac/pull/135) - Fix inferred dep path losing patch version by [@​itowlson](https://redirect.github.com/itowlson) in [https://github.com/bytecodealliance/wac/pull/138](https://redirect.github.com/bytecodealliance/wac/pull/138) - Add first version of targets command by [@​rylev](https://redirect.github.com/rylev) in [https://github.com/bytecodealliance/wac/pull/132](https://redirect.github.com/bytecodealliance/wac/pull/132) - Update warg 0.9 by [@​calvinrp](https://redirect.github.com/calvinrp) in [https://github.com/bytecodealliance/wac/pull/140](https://redirect.github.com/bytecodealliance/wac/pull/140) **Full Changelog**: bytecodealliance/wac@v0.5.0...v0.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #115
This adds a
wac targetssubcommand for determining whether a given component targets a given world. See the README changes for how this command is supposed to be used.The implementation is fairly naive, and I'm unsure if it's the best way to go about it. Because type checking relies on all types by populating in a
Typescollection, we load everything intoPackagewhich handles populating theTypescollection. APackagerequires a valid component, so we first convert the wit package into a component withwit-component. This does mean we have to dig into package to get the actual world id we care about though.@peterhuene let me know if I'm missing something here, but I think this is probably the best way to do this for now.
In the future, we want to expose a programatic API so if we can figure out a way to populate a
Typescollection directly from awit_parser::Resolvethat might be the way to go.