Build against musl on linux#143
Merged
calvinrp merged 1 commit intobytecodealliance:mainfrom Oct 21, 2024
Merged
Conversation
calvinrp
approved these changes
Oct 21, 2024
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to using
crosseven on the x86_64 image, because it comes pre-installed withmusl-gcc. The alternative would be to add a step that doesapt-get update && apt-get install musl-toolsjust forx86_64-unknown-linux-muslbut I felt this was simpler and more consistent across the x86_64 and aarch64 linux targets.Happy to add a comment in the YAML file if we want that.
Fix #142