Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion crates/wac-graph/src/graph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ impl CompositionGraph {
if let NodeKind::Definition = node.kind {
log::debug!(
"removing type definition `{name}`",
name = node.name.as_ref().unwrap()
name = node.export.as_ref().unwrap()
);
let removed = self.defined.remove(&node.item_kind.ty());
assert!(removed.is_some());
Expand Down Expand Up @@ -1969,6 +1969,23 @@ mod test {
));
}

#[test]
fn it_can_remove_a_type_definition() {
let mut graph = CompositionGraph::new();
let ty_id = graph
.types_mut()
.add_defined_type(DefinedType::Alias(ValueType::Primitive(PrimitiveType::S32)));
let node_id = graph
.define_type("foo", Type::Value(ValueType::Defined(ty_id)))
.unwrap();

// Definition nodes store their name in `export`, not `name`.
// Removing a definition node should not panic.
graph.remove_node(node_id);

// Verify the definition and export were cleaned up
assert!(graph.get_export("foo").is_none());
}
#[test]
fn it_cleans_up_exports_on_unregister_package() {
let mut graph = CompositionGraph::new();
Expand Down