Fix stale exports/imports/definitions after unregister_package#191
Merged
fibonacci1729 merged 2 commits intobytecodealliance:mainfrom Feb 17, 2026
Merged
Conversation
unregister_package() called retain_nodes() to remove nodes associated with a package, but did not clean up the exports, defined, and imports maps. This left stale NodeIndex references that could cause panics or incorrect behavior when those maps were subsequently accessed. Now cleans up all three maps before removing nodes from the graph. Added a test that verifies exports are properly cleaned up after unregistering a package.
fibonacci1729
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unregister_package()calledretain_nodes()to remove nodes but did not clean up theexports,defined, andimportsmapsNodeIndexreferences that could cause panics or incorrect behavior when those maps were subsequently accessedTest plan
it_cleans_up_exports_on_unregister_packagethat registers a package, exports a node, unregisters, and verifies cleanupcargo test --workspace)