Replace panics with errors for unsupported heap type conversions#195
Merged
fibonacci1729 merged 2 commits intobytecodealliance:mainfrom Feb 17, 2026
Merged
Conversation
The From<wasmparser::HeapType> impl panicked on shared heap types and used todo!() for exact heap types. Converted the entire chain of From impls to TryFrom (HeapType, RefType, CoreType, and the Table/Global CoreExtern conversions) so that unsupported types produce proper errors instead of crashing at runtime. Updated all call sites in package.rs to propagate errors via try_into. Added tests verifying that shared and exact heap types return errors.
fibonacci1729
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From<wasmparser::HeapType>panicked on shared heap types and usedtodo!()for exact heap typesFromimpls toTryFromso unsupported types produce proper errors instead of crashing at runtime:HeapType: From<wasmparser::HeapType>→TryFromCoreRefType: From<wasmparser::RefType>→TryFromCoreType: From<wasmparser::ValType>→TryFromCoreExtern: From<wasmparser::TableType>→TryFromCoreExtern: From<wasmparser::GlobalType>→TryFrompackage.rsto propagate errors viatry_into()Test plan
heap_type_conversion.rsintegration tests:shared_heap_type_returns_error,exact_heap_type_returns_error,non_shared_heap_type_succeedscargo test --workspace)