Handle JoinError in registry download task results#196
Merged
fibonacci1729 merged 1 commit intobytecodealliance:mainfrom Feb 17, 2026
Merged
Handle JoinError in registry download task results#196fibonacci1729 merged 1 commit intobytecodealliance:mainfrom
fibonacci1729 merged 1 commit intobytecodealliance:mainfrom
Conversation
The unwrap() on the JoinResult from spawned download tasks would panic if a task panicked or was cancelled. Now maps the JoinError to a proper RegistryDownloadFailure error variant instead.
fibonacci1729
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unwrap()onJoinResultfrom spawned download tasks would panic if a task panicked or was cancelledJoinErrorto aRegistryDownloadFailureerror variant instead of panickingTest plan
cargo test --workspace)