Fix the encoding of imported resources in the CompositionGraph.#74
Merged
peterhuene merged 1 commit intomainfrom Apr 11, 2024
Merged
Fix the encoding of imported resources in the CompositionGraph.#74peterhuene merged 1 commit intomainfrom
CompositionGraph.#74peterhuene merged 1 commit intomainfrom
Conversation
This commit fixes the encoding of imported resources in the `CompositionGraph`. Previously a panic was encountered when the graph attempts to import, either explicitly or implicitly, a resource. The fix requires tracking the "owner" of an aliased resource so that the export on the owning interface may be aliased and used for type equality when encoding the resource import. Fixes #62.
Member
Author
|
@rylev this fixes only the |
rylev
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the encoding of imported resources in the
CompositionGraph.Previously a panic was encountered when the graph attempts to import, either explicitly or implicitly, a resource.
The fix requires tracking the "owner" of an aliased resource so that the export on the owning interface may be aliased and used for type equality when encoding the resource import.
Fixes #62.