Skip to content

Loosen restriction on top-level resource alias imports.#83

Merged
peterhuene merged 1 commit intobytecodealliance:mainfrom
rylev:allow-unowned-resource-alias
Apr 15, 2024
Merged

Loosen restriction on top-level resource alias imports.#83
peterhuene merged 1 commit intobytecodealliance:mainfrom
rylev:allow-unowned-resource-alias

Conversation

@rylev
Copy link
Collaborator

@rylev rylev commented Apr 15, 2024

Previously, we assumed that all resource aliases had some owning interface, but that might not be the case. Users can alias resources at the world level. This lifts two restrictions that erroneously encoded this incorrect assumption.

Fixes #81

Previously, we assumed that all resource aliases had some owning
interface, but that might not be the case. Users can alias resources at
the world level. This lifts two restrictions that erroneously encoded
this incorrect assumption.

Fixes bytecodealliance#81
@rylev rylev requested a review from peterhuene April 15, 2024 13:50
Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@peterhuene peterhuene merged commit dbffafd into bytecodealliance:main Apr 15, 2024
@rylev rylev deleted the allow-unowned-resource-alias branch April 15, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wac_types::Package::from_bytes fails with "should have owner" after #74

2 participants