Skip to content

Bump version to v0.5.0#87

Merged
abrown merged 1 commit intobytecodealliance:mainfrom
CaptainVincent:vincent/feature-load-named
Aug 15, 2023
Merged

Bump version to v0.5.0#87
abrown merged 1 commit intobytecodealliance:mainfrom
CaptainVincent:vincent/feature-load-named

Conversation

@CaptainVincent
Copy link
Contributor

@CaptainVincent CaptainVincent commented Aug 11, 2023

  • Bump version to v0.5.0
  • Regenerate generate.rs from #38
  • Support load_by_name

@abrown
Copy link
Member

abrown commented Aug 11, 2023

This looks good, but I would like a chance to clean up a couple things in the witx upstream before we do this bump. I'll do that early next week and then we can rebase this?

@CaptainVincent
Copy link
Contributor Author

CaptainVincent commented Aug 11, 2023

👌 Sure. I'll rebase my PR after the new witx release.

@CaptainVincent CaptainVincent force-pushed the vincent/feature-load-named branch from fb80671 to 7eea1c3 Compare August 13, 2023 00:37
@abrown
Copy link
Member

abrown commented Aug 15, 2023

Ok, I did a bunch of clean up on the specification. Feel free to use that latest WITX to regenerate these bindings.

@CaptainVincent
Bump version to v0.5.0
0ca3c8c 
* Bump version to v0.5.0
* Regenerate generate.rs
* Support load_named

Signed-off-by: vincent <vincent@secondstate.io>
@CaptainVincent CaptainVincent force-pushed the vincent/feature-load-named branch from 7eea1c3 to 0ca3c8c Compare August 15, 2023 17:36
@CaptainVincent
Copy link
Contributor Author

CaptainVincent commented Aug 15, 2023

I'm done with the updates. Could you please help review to see if there are any modifications needed?
Thank you.

@CaptainVincent CaptainVincent mentioned this pull request Aug 15, 2023
Merged
abrown
abrown approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrown abrown merged commit 0910649 into bytecodealliance:main Aug 15, 2023
@CaptainVincent
Copy link
Contributor Author

CaptainVincent commented Sep 11, 2023 •
edited
Loading

WasmEdge has taken the lead in supporting this feature and incorporated it into our examples.
And we almost completed its integration into our ggml (llm) backend implementation, and it will be released alongside the documentation, coming soon 🎉.

This is our complete example on how to use wasinn load_by_name to launch a GGML model.
https://github.com/second-state/WasmEdge-WASINN-examples/tree/master/wasmedge-ggml-llama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrown abrown abrown approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaptainVincent @abrown