This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Conversation
add `pulley_provenance_test_async_components` test set/restore executor before/after resuming fibers fix provenance violations related to component async state pointer Fixes #45 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
| /// call. | ||
| pub(crate) fn try_new(store: &mut StoreOpaque) -> Option<Self> { | ||
| let current_poll_cx = store.concurrent_async_state().current_poll_cx.get(); | ||
| let current_poll_cx = unsafe { &raw mut (*store.concurrent_async_state()).current_poll_cx }; |
Member
There was a problem hiding this comment.
I do still want to eventually come back and clean all this up, but we can leave that for a future "unsafe review"
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Collaborator
Author
|
Ok, I broke other stuff, too. Serves me right for not running more tests locally first. Will debug. |
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
pulley_provenance_test_async_componentstestset/restore executor before/after resuming fibers
fix provenance violations related to component async state pointer
Fixes #45