Merged
Conversation
Contributor
Author
|
I upgraded only the Ubuntu and MacOS CI for now, should we update everything (nuttx, sgx, release) to use version 20? |
Collaborator
Had better not, we haven't tested it a lot yet. Seems someone found and fixed an issue related to malloc in wasi-libc: |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
) wasi-sdk-20 supports older versions of glibc and allow us to use it in the CI with Ubuntu 20.04. Refer to https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20 And bytecodealliance#2021 for previous upgrade to wasi-sdk-20 pre-release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With respect to wasi-sdk 20 pre-release, wasi-sdk 20 supports older versions of glibc, allowing us to use it in the CI with Ubuntu 20.04.
See #2021 for previous upgrade to wasi-sdk 20 pre-release.