run_wasi_tests.sh: provide stdin by ourselves#2576
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Sep 22, 2023
Merged
run_wasi_tests.sh: provide stdin by ourselves#2576wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh merged 1 commit intobytecodealliance:mainfrom
Conversation
This improves test consistency between typical local environments and github runners. This is necessary for some of latest wasi-threads tests. Also, IIRC, wasmtime test runner does something similar and some of their WASI tests rely on it. cf. yamt/toywasm@570e670
This was referenced Sep 21, 2023
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
This improves test consistency between typical local environments and github runners. This is necessary for some of latest wasi-threads tests. cf. yamt/toywasm@570e670
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
On posix-like platforms, the rest of wasi-threads tests should pass after the recent changes including the following PRs: bytecodealliance#2516, bytecodealliance#2524, bytecodealliance#2529, bytecodealliance#2571, bytecodealliance#2576 and bytecodealliance#2582.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves test consistency between typical local environments and github runners.
This is necessary for some of latest wasi-threads tests.
Also, IIRC, wasmtime test runner does something similar and some of their WASI tests rely on it.
cf. yamt/toywasm@570e670