Add support for closing/renumbering preopen fds#2578
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Sep 26, 2023
Merged
Add support for closing/renumbering preopen fds#2578wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh merged 1 commit intobytecodealliance:mainfrom
Conversation
wenyongh
reviewed
Sep 23, 2023
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
Outdated
Show resolved
Hide resolved
zoraaver
force-pushed
the
overwrite-close-preopen
branch
4 times, most recently
from
e958c24 to
112a06b
Compare
There doesn't appear to be a clear reason not to support this behaviour. It seems it was disallowed previously as a precaution. See bytecodealliance/wasmtime@67e2e57 for more context.
zoraaver
force-pushed
the
overwrite-close-preopen
branch
from
112a06b to
46ed2b1
Compare
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
There doesn't appear to be a clear reason not to support this behavior. It seems it was disallowed previously as a precaution. See bytecodealliance/wasmtime@67e2e57 for more context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There doesn't appear to be a clear reason not to support this behaviour. It seems it was disallowed previously as a precaution. See bytecodealliance/wasmtime@67e2e57 for more context.