Remove provision of unnecessary fd rights#2579
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Sep 22, 2023
Merged
Remove provision of unnecessary fd rights#2579wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh merged 1 commit intobytecodealliance:mainfrom
Conversation
The WASI docs allow for fewer rights to be applied to an fd than requested but not more. This behaviour is also asserted in the rust WASI tests, so it's necessary for those to pass as well.
loganek
approved these changes
Sep 21, 2023
Contributor
loganek
left a comment
loganek
left a comment
There was a problem hiding this comment.
LGTM, let's make sure this is highlighted in the release notes.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
The WASI docs allow for fewer rights to be applied to an fd than requested but not more. This behavior is also asserted in the rust WASI tests, so it's necessary for those to pass as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASI docs allow for fewer rights to be applied to an fd than requested but not more. This behaviour is also asserted in the rust WASI tests, so it's necessary for those to pass as well.