Refactor clock functions to use WASI types#2666
Merged
wenyongh merged 1 commit intobytecodealliance:dev/wasi-libc-windowsfrom Oct 25, 2023
Merged
Refactor clock functions to use WASI types#2666wenyongh merged 1 commit intobytecodealliance:dev/wasi-libc-windowsfrom
wenyongh merged 1 commit intobytecodealliance:dev/wasi-libc-windowsfrom
Conversation
zoraaver
force-pushed
the
wasi-clock-refactor
branch
2 times, most recently
from
3442d2e to
3c53fa7
Compare
loganek
reviewed
Oct 24, 2023
zoraaver
force-pushed
the
wasi-clock-refactor
branch
2 times, most recently
from
6b1c42c to
7a5d3de
Compare
wenyongh
reviewed
Oct 25, 2023
Collaborator
wenyongh
left a comment
wenyongh
left a comment
There was a problem hiding this comment.
LGTM, could you resolve the conflict issues introduced by the merging of last PR?
zoraaver
force-pushed
the
wasi-clock-refactor
branch
from
7a5d3de to
c12e071
Compare
Refactoring the clock functions to use WASI types so we can simplify the code and remove some unnecessary boilerplate. See bytecodealliance#2637 (comment) for details.
zoraaver
force-pushed
the
wasi-clock-refactor
branch
from
c12e071 to
1c63c80
Compare
Contributor
Author
|
I've rebased and resolved the conflicts |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Refactoring the clock functions to use WASI types so we can simplify the code and remove some unnecessary boilerplate. See bytecodealliance#2637 (comment) for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the clock functions to use WASI types so we can simplify the code and remove some unnecessary boilerplate. See
#2637 (comment) for details.