Skip to content

Add a checker if indices might overflow UINT32_MAX#3579

Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom
lum1n0us:fix/indices_overflow
Jul 2, 2024
Merged

Add a checker if indices might overflow UINT32_MAX#3579
wenyongh merged 1 commit intobytecodealliance:mainfrom
lum1n0us:fix/indices_overflow

Conversation

@lum1n0us
Copy link
Contributor

@lum1n0us lum1n0us commented Jul 1, 2024

69920

may just pick one between this one and #3577

@lum1n0us lum1n0us force-pushed the fix/indices_overflow branch from a109538 to b3f35eb Compare July 1, 2024 06:53
Copy link
Collaborator

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TianlongLiang
Copy link
Contributor

LGTM

@yamt
Copy link
Contributor

yamt commented Jul 1, 2024

can you do the same for other resources as well?
memories, tables, tags.

@lum1n0us
Copy link
Contributor Author

lum1n0us commented Jul 2, 2024

Sure. But since wamr haven't support multi-tables and multi-memories yet, I'll patch tag only.

@lum1n0us lum1n0us force-pushed the fix/indices_overflow branch from b3f35eb to faa18d2 Compare July 2, 2024 01:36
@wenyongh wenyongh merged commit f118492 into bytecodealliance:main Jul 2, 2024
@lum1n0us lum1n0us deleted the fix/indices_overflow branch November 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants