Skip to content

wasm loader: Fix several issues in GC and exception handling#3586

Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh:fix_loader_issues
Jul 5, 2024
Merged

wasm loader: Fix several issues in GC and exception handling#3586
wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh:fix_loader_issues

Conversation

@wenyongh
Copy link
Collaborator

@wenyongh wenyongh commented Jul 2, 2024

Fix several issues of GC and exception handling in wasm loader:

  • Should restore param_reftype_maps/param_reftype_map_count/param_count
    in the handling of opcode throw
  • Should set wasm_ref_type when pushing param types of tag type and block type
    if the type is a multi-byte type
  • Should set init_values.data as NULL for opcode struct.new_default in load_init_expr

This PR fixes the issues reported in #3411.

@wenyongh wenyongh changed the title wasm loader: Fix several issues of GC and exception handling wasm loader: Fix several issues in GC and exception handling Jul 4, 2024
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 0feae05 into bytecodealliance:main Jul 5, 2024
@wenyongh wenyongh deleted the fix_loader_issues branch July 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants