spec-test-script/runtest.py: don't assume the tmp dir path#3632
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Jul 18, 2024
Merged
spec-test-script/runtest.py: don't assume the tmp dir path#3632wenyongh merged 1 commit intobytecodealliance:mainfrom
wenyongh merged 1 commit intobytecodealliance:mainfrom
Conversation
The current coding assumes the tmp file is created in /tmp. However, * It's somewhere under /var/folders/... by default on macOS. * A user can set TMPDIR.
wenyongh
reviewed
Jul 17, 2024
| log("Starting interpreter for module '%s'" % tmpfile) | ||
|
|
||
| if opts.qemu: | ||
| tmpfile = f"/tmp/{os.path.basename(tmpfile)}" |
Collaborator
There was a problem hiding this comment.
Is better to move L1159 to be after these two lines, or the log may be not so accurate?
Contributor
Author
There was a problem hiding this comment.
L1159 is the path on the host.
L1162 is the path in qemu.
wenyongh
reviewed
Jul 17, 2024
| log("Starting interpreter for module '%s'" % tmpfile) | ||
|
|
||
| if opts.qemu: | ||
| tmpfile = f"/tmp/{os.path.basename(tmpfile)}" |
no1wudi
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current coding assumes the tmp file is created in /tmp. However,
It's somewhere under /var/folders/... by default on macOS.
A user can set TMPDIR.