Skip to content

wamr-test-suites/test_wamr.sh: add an option to specify wamrc binary#3635

Merged
wenyongh merged 2 commits intobytecodealliance:mainfrom
yamt:aot-compiler-option
Jul 18, 2024
Merged

wamr-test-suites/test_wamr.sh: add an option to specify wamrc binary#3635
wenyongh merged 2 commits intobytecodealliance:mainfrom
yamt:aot-compiler-option

Conversation

@yamt
Copy link
Contributor

@yamt yamt commented Jul 17, 2024

No description provided.

yamt added 2 commits July 17, 2024 10:30
To be consistent with wasi_test.py and runtest.py.

Probably this is not strictly necessary as runtest.py
uses the WAMRC_CMD environment variable.
@HongxiaWangSSSS
Copy link
Contributor

Hi yamt-san,
I'd like to know why use external wamrc in ci? Sometimes using the wrong version of wamrc may also cause the test to fail, like aot in different formats, unsolved issues.
Maybe the wamrc generated using the current version better reflects the accuracy of the test.
If it is about the xtensa platform, I prefer according the platform build different wamrc in the current wamr.

@yamt
Copy link
Contributor Author

yamt commented Jul 17, 2024

I'd like to know why use external wamrc in ci?

i occasionally run this script locally and i often have a wamrc binary to use.

@yamt yamt mentioned this pull request Jul 17, 2024
Copy link
Collaborator

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 9f637e6 into bytecodealliance:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants