Skip to content

spec_test_on_nuttx.yml: replace sed with kconfig-tweak#3672

Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom
yamt:kconfig-tweak
Jul 31, 2024
Merged

spec_test_on_nuttx.yml: replace sed with kconfig-tweak#3672
wenyongh merged 1 commit intobytecodealliance:mainfrom
yamt:kconfig-tweak

Conversation

@yamt
Copy link
Contributor

@yamt yamt commented Jul 29, 2024

Fixes: #3646

@yamt yamt marked this pull request as ready for review July 29, 2024 04:55
@wenyongh wenyongh requested a review from no1wudi July 29, 2024 11:46
kconfig-tweak --enable CONFIG_RISCV_SEMIHOSTING_HOSTFS_CACHE_COHERENCE
kconfig-tweak --enable CONFIG_XTENSA_SEMIHOSTING_HOSTFS
kconfig-tweak --enable CONFIG_XTENSA_SEMIHOSTING_HOSTFS_CACHE_COHERENCE
kconfig-tweak --enable CONFIG_EOL_IS_LF
Copy link
Collaborator

@no1wudi no1wudi Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it ? EOL_IS_LF seems removed from NuttX in recent version

Copy link
Contributor Author

@yamt yamt Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe. i don't want to make unrelated changes in this PR though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenyongh wenyongh merged commit c3bd6b4 into bytecodealliance:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spec_test_on_nuttx.yml should not edit kconfig files with sed

3 participants