add missing typedefs and headers#3715
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Aug 15, 2024
Merged
Conversation
wenyongh
reviewed
Aug 15, 2024
core/shared/utils/bh_atomic.h
Outdated
| #ifndef _BH_ATOMIC_H | ||
| #define _BH_ATOMIC_H | ||
|
|
||
| #include <stdint.h> |
Collaborator
There was a problem hiding this comment.
Could you include bh_platform.h instead? like other files of this folder.
core/shared/utils/bh_atomic.h
Outdated
|
|
||
| typedef uint64_t uint64; | ||
| typedef uint32_t uint32; | ||
| typedef uint16_t uint16; |
Collaborator
There was a problem hiding this comment.
If including bh_platform.h, we don't need to add the three lines, since these types are already defined in the platform's header files.
wenyongh
reviewed
Aug 15, 2024
sjamesr
force-pushed
the
add_llvm_defines
branch
from
5f752ad to
faf930b
Compare
wenyongh
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.