Refine wasm/aot function instance lookup#3865
Merged
wenyongh merged 4 commits intobytecodealliance:mainfrom Oct 18, 2024
Merged
Refine wasm/aot function instance lookup#3865wenyongh merged 4 commits intobytecodealliance:mainfrom
wenyongh merged 4 commits intobytecodealliance:mainfrom
Conversation
wenyongh
requested review from
loganek,
lum1n0us,
no1wudi,
xujuntwt95329 and
yamt
as code owners
lum1n0us
approved these changes
Oct 18, 2024
Contributor
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
LGTM.
followings include giving name to wasm_exter_t in interp_process_export() and aot_process_export().
yamt
reviewed
Oct 18, 2024
Zzzabiyaka
pushed a commit
to Zzzabiyaka/wasm-micro-runtime
that referenced
this pull request
Oct 22, 2024
Sort the module instance's export functions with the function name, and use binary search to lookup the wasm/aot function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the module instance's export functions with the function name,
and use binary search to lookup the wasm function.