[instantiation linking] create and import WASMMemoryInstance for aot #3887
Merged
lum1n0us merged 14 commits intobytecodealliance:dev/instantiate_linkingfrom Nov 20, 2024
Merged
Conversation
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
5 times, most recently
from
9ef6ec2 to
730cd55
Compare
lum1n0us
requested review from
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
This was referenced Nov 3, 2024
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
from
730cd55 to
15f9ad5
Compare
- ~99% same with memory_instantiation() in wasm_runtime.c - new apis to create and destroy memory
…tantiation logic in wasm_runtime.c
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
from
15f9ad5 to
878287d
Compare
lum1n0us
commented
Nov 4, 2024
wenyongh
reviewed
Nov 18, 2024
lum1n0us
force-pushed
the
feat_inst_linking_memory_aot
branch
from
878287d to
b0cc5ce
Compare
…nd remove unused code
wenyongh
reviewed
Nov 18, 2024
Collaborator
wenyongh
left a comment
wenyongh
left a comment
There was a problem hiding this comment.
Had better test whether the AOT file compiled by older wamrc work in the new code?
Contributor
Author
Agreed. I intend to do that once all four |
lum1n0us
added a commit
to lum1n0us/wasm-micro-runtime
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #3845