Add v128.load32_zero and v128.load64_zero SIMD instructions #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, and a dot release would be great once these are approved & incorporated. |
Member
|
Published! I also added a small fixup since the text parser didn't seem to encode the memory immediate |
Contributor
Author
|
Thanks! I apparently don't know my way around this code very well yet... |
Contributor
Author
|
@alexcrichton, actually looking at that fixup: it looks like the argument to MemArg used there is the log of the byte size of the datum, but all other uses of MemArg in that file carry the byte size of the datum. Care to comment? |
Member
|
Oh dear looks like I've also forgotten my way around the code! I'll fix that and publish a release |
Member
|
Opened as #120 |
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These opcodes were promoted to standards track last Friday: WebAssembly/simd#237 (comment)