Update the spec test suite submodule#1576
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom May 28, 2024
Merged
Update the spec test suite submodule#1576alexcrichton merged 3 commits intobytecodealliance:mainfrom
alexcrichton merged 3 commits intobytecodealliance:mainfrom
Conversation
This commit updates the spec test suite submodule and notably implements the extended syntax in the text format for quoted identifiers. Names such as `$"foo"` are not valid and equivalent to `$foo`. This doesn't yet update any `wasmprinter`-based printing to use this new syntax, it's just parsed to pass the various spec tests added. This additionally updates the lexer to have a first-class notion of an annotation instead of being lumped in with "reserved" tokens to avoid having to deal with things like `@"foo""bar"` which is a single reserved token but technically not an annotation. This is now modelled differently within the lexer as `TokenKind::Annotation` or `TokenKind::Reserved`. (and can have a better first-class error in the future).
pchickey
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the spec test suite submodule and notably implements the extended syntax in the text format for quoted identifiers. Names such as
$"foo"are now valid and equivalent to$foo. This doesn't yet update anywasmprinter-based printing to use this new syntax, it's just parsed to pass the various spec tests added.This additionally updates the lexer to have a first-class notion of an annotation instead of being lumped in with "reserved" tokens to avoid having to deal with things like
@"foo""bar"which is a single reserved token but technically not an annotation. This is now modelled differently within the lexer asTokenKind::AnnotationorTokenKind::Reserved. (and can have a better first-class error in the future).