wasm-tools, wit-parser: add --all-features to enable all features gated with @unstable#1599
Conversation
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Mind also adding a test along the lines of this one? (no need to be so exhaustive, but it'd be good to have at least one test for the flags)
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Can you elaborate on why to support --features . though? I've not personally seen precedent for something like that and it feels a bit odd to me that . means "everything". I'd personally be in favor of just sticking with --all-features myself.
Happy to revert this if that’s what gets it done. |
|
That's true about regexes, although I'd expect |
This PR adds the
--all-featuresoption towasm-tools component, primarily sowasm-tools component wit -jcan emit a JSON representation of the original WIT with all@unstablegated features intact.It additionally adds support for
--features .as an alias for--all-features.Originally proposed here: https://bytecodealliance.zulipchat.com/#narrow/stream/327223-wit-bindgen/topic/wit-parser.20crate.3A.20JSON.20format.20changes/near/443516048